linux-kernel - Re: [PATCH] spi: spidev: only use up TX/RX bounce buffer space when needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 16 Feb 2015 14:33:37 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	Mark Brown <broonie@...nel.org>
CC:	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: spidev: only use up TX/RX bounce buffer space when
 needed

On 16/02/15 13:23, Mark Brown wrote:
> On Mon, Feb 16, 2015 at 10:18:01AM +0000, Ian Abbott wrote:
>> On 16/02/15 04:13, Mark Brown wrote:
 >>> On Sun, Feb 15, 2015 at 10:30:22AM +0000, Ian Abbott wrote:
>>>> The check against INT_MAX is there because a struct spi_ioc_transfer might
>>>> have rx_buf==NULL, tx_buf==NULL and len!=0, in which case it would no longer
>>>> use up space in either of the pre-allocated buffers so neither rx_total nor
>>>> tx_total would increase.  Checking the sum of the len fields against INT_MAX
>>>> prevents arithmetic overflow in the return value of the function.
>
>>> If that's what the code is supposed to do then someone reading the code
>>> needs to be able to tell that without too much effort, I'd not expect
>>> that to be possible as things are.  Maintainability is very important.
>
>> There was a whole paragraph about that in the commit message, but maybe it
>> was too concise.
>
> The commit message is not the code.  The code itself needs to be clear,
> and even based on what's in the commit message it's not terribly obvious
> (and with the above the return value that will be overflowed doesn't
> jump out).

Good point.  I'll add some comments to the code.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/