linux-kernel - Re: [PATCH v3 1/2] dgnc: Remove superfluous EXTRA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1424097995.4865.2.camel@cassm.net>
Date:	Mon, 16 Feb 2015 14:46:35 +0000
From:	Cass May <cass@...sm.net>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	lidza.louina@...il.com, markh@...pro.net,
	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dgnc: Remove superfluous EXTRA_CFLAGS variable

On Mon, 2015-02-16 at 12:12 +0300, Dan Carpenter wrote:
> On Sun, Feb 15, 2015 at 11:40:17PM +0000, Cass May wrote:
> > Clean up Makefile by removing unnecessary definition of DG_NAME.
> > 
> > Signed-off-by: Cass May <cass@...sm.net>
> > ---
> > Having done some build tests, it seems that DG_NAME is not needed, 
> > but DG_PART is referenced in dgnc_mgmt.c. I have removed the former, 
> > and moved the latter into the appropriate header. 
> 
> Thanks!
> 
> Don't resend; this patch is great.  But next time just fold both patches
> together into one patch.  It's all part of the same fix really so it
> falls into the "one thing per patch" rule.
> 
> regards,
> dan carpenter

Shall do! Thank you for the guidance. 

-cass

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/