linux-kernel - Re: [PATCH 1/2] extcon: arizona: Deobfuscate arizona_extcon_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGTfZH3J6u0MpJdd4kxY31OFHqo8QU2-2t0LzKgxUYP1b5qdEw@mail.gmail.com>
Date:	Tue, 17 Feb 2015 01:48:10 +0900
From:	Chanwoo Choi <cwchoi00@...il.com>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	"myungjoo.ham@...sung.com" <myungjoo.ham@...sung.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	patches@...nsource.wolfsonmicro.com,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] extcon: arizona: Deobfuscate arizona_extcon_do_magic

Hi Charles,


On Tue, Feb 17, 2015 at 12:41 AM, Charles Keepax
<ckeepax@...nsource.wolfsonmicro.com> wrote:
> arizona_extcon_do_magic does not lend a lot of clarity to the purpose
> of the function, and as all the registers used are described in the
> datasheet there is no need to obfuscate the code. This patch renames the
> function to arizona_extcon_hp_clamp, as it controls clamping on the
> headphone output.
>
> Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> ---
>  drivers/extcon/extcon-arizona.c  |   36 ++++++++++++++++++++----------------
>  include/linux/mfd/arizona/core.h |    2 +-
>  sound/soc/codecs/arizona.c       |    4 ++--
>  3 files changed, 23 insertions(+), 19 deletions(-)


Looks good to me.
But, you need more ack message by MFD maintainer.

For extcon part:
Acked-by: Chanwoo Choi <cw00.choi@...sung.com>

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/