lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Feb 2015 17:28:42 +0000 From: Alexander Gordeev <agordeev@...hat.com> To: Tejun Heo <tj@...nel.org> Cc: Stefan Bader <stefan.bader@...onical.com>, Sander Eikelenboom <linux@...elenboom.it>, linux-kernel@...r.kernel.org Subject: Re: 3.19: device name associates with IRQ's for ahci controllers operating with a single IRQ changed from "ahci?" to "<BDF>" On Tue, Feb 10, 2015 at 09:51:20AM -0500, Tejun Heo wrote: > Hello, > > On Tue, Feb 10, 2015 at 08:57:46AM +0100, Stefan Bader wrote: > > On 09.02.2015 20:54, Sander Eikelenboom wrote: > > > Hi. > > > > > > In 3.19 the device name associates with IRQ's for ahci controllers operating > > > with a single IRQ changed from "ahci?" to "<BDF>", was this intentional ? > > > > > > It's probably commit 18dcf433f3ded61eb140a55e7048ec2fef79e723 (or another one > > > in that series). > > > > Oh, looking at that commit that might make sense. In > > ahci_host_activate_single_irq it now uses dev_driver_name instead of dev_name as > > it did before (from ata_host_activate). The description sounds like before the > > driver is registered this will return the bus. And registering an interrupt > > would likely be before the driver is fully registered... But you probably saw > > that, too. Whether that really was intentional is still the question. :) > > Urgh... Alexander, can you please send a patch to fix up the names? The problem dates back to commit 4f37b50 ("libata: Use dev_name() for request_irq() to distinguish devices"). If the commit is considered valid then <BDF> still might be legitimate as well. Not sure what is the best approach here. > Thanks. > > -- > tejun -- Regards, Alexander Gordeev agordeev@...hat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists