linux-kernel - Re: [PATCH 1/8] x86, fpu: unlazy_fpu: don't reset thread.fpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Feb 2015 12:58:37 -0500
From:	Rik van Riel <riel@...hat.com>
To:	Borislav Petkov <bp@...en8.de>, oleg@...hat.com
CC:	dave.hansen@...ux.intel.com, sbsiddha@...il.com,
	luto@...capital.net, tglx@...utronix.de, mingo@...nel.org,
	hpa@...or.com, fenghua.yu@...el.com, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/8] x86, fpu: unlazy_fpu: don't reset thread.fpu_counter

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/16/2015 12:04 PM, Borislav Petkov wrote:

> ... and so by looking at the unlazy_fpu() call sites, I think this
> makes sense.
> 
> So how's that for a commit message instead:
> 
> --- x86, fpu, unlazy_fpu: Don't reset thread.fpu_counter
> 
> The "else" branch clears ->fpu_counter as a remnant of the lazy
> FPU usage counting:
> 
> e07e23e1fd30 ("[PATCH] non lazy "sleazy" fpu implementation")
> 
> However, switch_fpu_prepare() does this now so that else branch is 
> superfluous.
> 
> If we do use_eager_fpu(), then this has no effect. Otherwise, if
> we actually wanted to prevent fpu preload after the context switch
> we would need to reset it unconditionally, even if
> __thread_has_fpu(). ---
> 
> ?

Good detective work.

Your changelog makes sense to me.

- -- 
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJU4i/NAAoJEM553pKExN6DWn4H/ArcSaAwA5ClOmxNACOTS644
m+8d/+3XZd+nWKBxLY2iyigLQ3FSek2dPSilDMSxtN97oFsG9mFw14gvP1/oR9OU
6vVhfuBWPRQ+Ay7CAL40v1acvzbYSTQJ6i9IJq20EFhuAS1CFwksOr9gQrhRHed1
FxFUpSnss0+p6Jp+RXY+UG2gNtSUOwgLzZFb1cmgeD5APC+RShGqHgDPTlNUESGK
f9g3QzOD3KAz8fVNzTwumN1nJzPNx6yBXuazu3U8HAxzcMskVvWSOEyEBlo48CdR
XxjLpI95qgzwUUQGFj6yax8ciq6nQGk6TsgqbdqHlpHSQ2zWU1F8XefGAS/r0vE=
=CXAX
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/