linux-kernel - [PATCH 3/3] proc: fix /proc/<pid>/stack for running tasks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <141f750fd50cba5fb94cf4649dd7517c3d569744.1424109806.git.jpoimboe@redhat.com>
Date:	Mon, 16 Feb 2015 12:52:36 -0600
From:	Josh Poimboeuf <jpoimboe@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>
Cc:	Jiri Kosina <jkosina@...e.cz>, Seth Jennings <sjenning@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH 3/3] proc: fix /proc/<pid>/stack for running tasks

Reading /proc/<pid>/stack for a running task can show garbage.  Use the
new safe version of the stack saving interface.  For running tasks
(other than current) it won't show anything.

Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
---
 fs/proc/base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/proc/base.c b/fs/proc/base.c
index 3f3d7ae..4c3f5d5 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -288,7 +288,7 @@ static int proc_pid_stack(struct seq_file *m, struct pid_namespace *ns,
 
 	err = lock_trace(task);
 	if (!err) {
-		save_stack_trace_tsk(task, &trace);
+		save_stack_trace_tsk_safe(task, &trace);
 
 		for (i = 0; i < trace.nr_entries; i++) {
 			seq_printf(m, "[<%pK>] %pS\n",
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/