linux-kernel - Re: [PATCH] lib/vsprintf.c:Avoid extra operation in dentry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFLxGvzZ+n6jNKB_R-0QC=adzg8t2JAGG8Wcy1mWT1S66NCjsA@mail.gmail.com>
Date:	Mon, 16 Feb 2015 20:14:05 +0100
From:	Richard Weinberger <richard.weinberger@...il.com>
To:	Anshul Garg <aksgarg1989@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, anshul.g@...sung.com,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] lib/vsprintf.c:Avoid extra operation in dentry_name

On Mon, Feb 16, 2015 at 7:49 PM, Anshul Garg <aksgarg1989@...il.com> wrote:
> From: Anshul Garg <aksgarg1989@...il.com>
>
> Remove unnecessary increment and decrement operation
> in dentry_name function as after increment operation
> loop is breaked and then decrement operation is
> performed. So remove increment and decrement operation
> from the function.
>
> Signed-off-by: Anshul Garg <aksgarg1989@...il.com>
> ---
>  lib/vsprintf.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index ec337f6..2a38105 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -576,11 +576,10 @@ char *dentry_name(char *buf, char *end, const struct dentry *d, struct printf_sp
>                 if (p == d) {
>                         if (i)
>                                 array[i] = "";
> -                       i++;
>                         break;
>                 }
>         }
> -       s = array[--i];
> +       s = array[i];
>         for (n = 0; n != spec.precision; n++, buf++) {
>                 char c = *s++;
>                 if (!c) {

What if the if (d == d) branch is not taken?
Does the code then really behave exactly as before?

-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/