linux-kernel - Re: [PATCH] scsi/lpfc: use remove handler as shutdown handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54E24806.5030605@emulex.com>
Date:	Mon, 16 Feb 2015 14:41:58 -0500
From:	James Smart <james.smart@...lex.com>
To:	Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>
CC:	<linux-scsi@...r.kernel.org>, <JBottomley@...allels.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi/lpfc: use remove handler as shutdown handler

Looks good.

Acked-By: James Smart  <james.smart@...lex.com>

-- james



On 1/26/2015 10:18 AM, Thadeu Lima de Souza Cascardo wrote:
> Without a shutdown handler, some cards behave very badly after a kexec.
> During probe, pending DMA writes will corrupt kernel memory, for
> example.
>
> Using the remove handler guarantees we will use a well tested path.
>
> With this patch I applied, I managed to use kexec multiple times and
> probe and SCSI scan worked every time.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>
> ---
>   drivers/scsi/lpfc/lpfc_init.c |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index 0b2c53a..8aa804a 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -11248,6 +11248,7 @@ static struct pci_driver lpfc_driver = {
>   	.id_table	= lpfc_id_table,
>   	.probe		= lpfc_pci_probe_one,
>   	.remove		= lpfc_pci_remove_one,
> +	.shutdown	= lpfc_pci_remove_one,
>   	.suspend        = lpfc_pci_suspend_one,
>   	.resume		= lpfc_pci_resume_one,
>   	.err_handler    = &lpfc_err_handler,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/