linux-kernel - Re: [PATCH] module: do not print allocation-fail warning on bogus user buffer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8761b1tnqz.fsf@rustcorp.com.au>
Date:	Tue, 17 Feb 2015 10:25:48 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Dave Jones <davej@...emonkey.org.uk>,
	Sasha Levin <sasha.levin@...cle.com>
Subject: Re: [PATCH] module: do not print allocation-fail warning on bogus user buffer size

"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com> writes:
> init_module(2) passes user-specified buffer length directly to
> vmalloc(). It makes warn_alloc_failed() to print out a lot of info into
> dmesg if user specified insane size, like -1.
>
> Let's silence the warning. It doesn't add much value to -ENOMEM return
> code. Without the patch the syscall is prohibitive noisy for testing
> with trinity.

Heh, we used to have an explicit length check because vmalloc would
BUG().  So I guess this is progress...

Applied thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/