linux-kernel - Re: [GIT PULL] x86/apic updates for v3.20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 16 Feb 2015 08:22:04 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Joerg Roedel <joro@...tes.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [GIT PULL] x86/apic updates for v3.20


* Joerg Roedel <joro@...tes.org> wrote:

> On Thu, Feb 12, 2015 at 06:08:45PM -0800, Linus Torvalds wrote:
> > Any ideas? The Pixel Chromebook does have an odd and often broken
> > BIOS/firmware thing, but it *used* to suspend and resume very reliably
> > once we got around its insane TPM thing.
> 
> Hmm, looking at the patch and the surrounding code my guess is that
> x2apic gets enabled now with 5fcee53ce705 on your Chromebook Pixel at
> boot, which causes the suspend issue later for other reasons.
> 
> So the condition should rather look like this to keep x2apic disabled
> like before:
> 
> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> index b665d24..770a0bb 100644
> --- a/arch/x86/kernel/apic/apic.c
> +++ b/arch/x86/kernel/apic/apic.c
> @@ -1580,8 +1580,8 @@ static __init void try_to_enable_x2apic(int remap_mode)
>  		 * under KVM
>  		 */
>  		if (max_physical_apicid > 255 ||
> -		    (IS_ENABLED(CONFIG_HYPERVISOR_GUEST) &&
> -		     !hypervisor_x2apic_available())) {
> +		    !(IS_ENABLED(CONFIG_HYPERVISOR_GUEST) &&
> +		      hypervisor_x2apic_available())) {
>  			pr_info("x2apic: IRQ remapping doesn't support X2APIC mode\n");
>  			x2apic_disable();
>  			return;

Indeed!

> Another solution would be to just revert 5fcee53ce705. 
> This code is not in any fast-path, so we can live well 
> without that optimization.

Agreed.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/