linux-kernel - Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201502170909.02767.marex@denx.de>
Date:	Tue, 17 Feb 2015 09:09:02 +0100
From:	Marek Vasut <marex@...x.de>
To:	Stefan Wahren <stefan.wahren@...e.com>
Cc:	Fabio Estevam <festevam@...il.com>,
	Sascha Hauer <kernel@...gutronix.de>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	Shawn Guo <shawn.guo@...aro.org>,
	Mike Turquette <mturquette@...aro.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>, Zhi Li <lznuaa@...il.com>
Subject: Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

On Monday, February 16, 2015 at 09:24:51 PM, Stefan Wahren wrote:
> Hi Fabio,
> 
> > Fabio Estevam <festevam@...il.com> hat am 12. Februar 2015 um 20:08
> > geschrieben:
> > 
> > 
> > Hi Stefan,
> > 
> > On Thu, Feb 12, 2015 at 4:59 PM, Stefan Wahren <stefan.wahren@...e.com> 
wrote:
> > > Hi Fabio,
> > > 
> > >> Fabio Estevam <festevam@...il.com> hat am 11. Februar 2015 um 22:10
> > >> geschrieben:
> > >> 
> > >> 
> > >> On Wed, Feb 11, 2015 at 6:31 PM, Stefan Wahren
> > >> <stefan.wahren@...e.com>
> > >> 
> > >> wrote:
> > >> >> I always get 0x5e5b5513 with or without your patch.
> > >> > 
> > >> > very strange. Do you have any idea why IO1_STABLE is permanent low?
> > >> 
> > >> On my case it is always 1.
> > > 
> > > i expected the same behavior on my hardware.
> > > 
> > > Do you use u-boot as bootloader?
> > 
> > Yes, I do.
> 
> i will try to test it with u-boot.
> 
> > >> > Can you confirm the behavior according to your flash issue?
> > >> 
> > >> In my tests IO1_STABLE stays the same.
> > > 
> > > This wasn't the intension of my second question. I wanted to know about
> > > the state of the SPI NOR flash detection process.
> > > 
> > > Does it sucessed if you apply the patch, but revert the changes in
> > > clk_ref_set_rate() from clk-ref.c?
> > 
> > I don't have my mx28evk setup available at the moment, but when I
> > applied your patch and reverted all the changes in clk-ref.c, then the
> > SPI flash detection works.
> > 
> > I haven't tested to only reverting the changes inside
> > clk_ref_set_rate(), but I can do it tomorrow.
> 
> I think the reason for the problem in the flash detection is caused by the
> misaligned access on the frac register.

Misaligned ? In which way ? Can you please elaborate on this ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/