linux-kernel - Re: [PATCH 2/3] pm: at91: pm_suspend: MOR register KEY was missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150217102411.GC11529@piout.net>
Date:	Tue, 17 Feb 2015 11:24:11 +0100
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Wenyou Yang <wenyou.yang@...el.com>
Cc:	nicolas.ferre@...el.com, linux@...im.org.za,
	linux@....linux.org.uk, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, sylvain.rochet@...secur.com,
	patrice.vilchez@...el.com, sergei.shtylyov@...entembedded.com,
	mark.rutland@....com, lorenzo.pieralisi@....com
Subject: Re: [PATCH 2/3] pm: at91: pm_suspend: MOR register KEY was missing

On 12/02/2015 at 10:52:13 +0800, Wenyou Yang wrote :
> From: Patrice Vilchez <patrice.vilchez@...el.com>
> 
> Because writing the MOR register requires the PASSWD(0x37),
> if missed, the write operation will be aborted.
> 
> Signed-off-by: Patrice Vilchez <patrice.vilchez@...el.com>
Acked-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>

> ---
>  arch/arm/mach-at91/pm_suspend.S |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
> index 1c7256a..5347ad4 100644
> --- a/arch/arm/mach-at91/pm_suspend.S
> +++ b/arch/arm/mach-at91/pm_suspend.S
> @@ -132,6 +132,7 @@ ENTRY(at91_pm_suspend_in_sram)
>  	/* Turn off the main oscillator */
>  	ldr	tmp1, [pmc, #AT91_CKGR_MOR]
>  	bic	tmp1, tmp1, #AT91_PMC_MOSCEN
> +	orr	tmp1, tmp1, #AT91_PMC_KEY
>  	str	tmp1, [pmc, #AT91_CKGR_MOR]
>  
>  skip_disable_main_clock:
> @@ -149,6 +150,7 @@ skip_disable_main_clock:
>  	/* Turn on the main oscillator */
>  	ldr	tmp1, [pmc, #AT91_CKGR_MOR]
>  	orr	tmp1, tmp1, #AT91_PMC_MOSCEN
> +	orr	tmp1, tmp1, #AT91_PMC_KEY
>  	str	tmp1, [pmc, #AT91_CKGR_MOR]
>  
>  	wait_moscrdy
> -- 
> 1.7.9.5
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/