linux-kernel - Re: [PATCH 2/4] hw_random: bcm63xx-rng: move register definitions to driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Feb 2015 14:35:20 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Florian Fainelli <f.fainelli@...il.com>, linux-mips@...ux-mips.org
CC:	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	mpm@...enic.com, herbert@...dor.apana.org.au, wsa@...-dreams.de,
	cernekee@...il.com
Subject: Re: [PATCH 2/4] hw_random: bcm63xx-rng: move register definitions
 to driver

Hello.

On 2/17/2015 5:09 AM, Florian Fainelli wrote:

> arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h contains the register
> definitions for this random number generator block, incorporate these
> register definitions directly into the bcm63xx-rng driver so we do not
> rely on this header to be provided.

> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>   drivers/char/hw_random/bcm63xx-rng.c | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)

> diff --git a/drivers/char/hw_random/bcm63xx-rng.c b/drivers/char/hw_random/bcm63xx-rng.c
> index ed9b28b35a39..c7f3af852599 100644
> --- a/drivers/char/hw_random/bcm63xx-rng.c
> +++ b/drivers/char/hw_random/bcm63xx-rng.c
> @@ -13,7 +13,15 @@
>   #include <linux/platform_device.h>
>   #include <linux/hw_random.h>
>
> -#include <bcm63xx_regs.h>
> +#define RNG_CTRL			0x00
> +#define RNG_EN				(1 << 0)
> +
> +#define RNG_STAT			0x04
> +#define RNG_AVAIL_MASK			(0xff000000)

    Parens not needed here.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/