linux-kernel - Re: [PATCH 1/2] extcon: arizona: Deobfuscate arizona_extcon_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150217015614.GR9110@finisterre.sirena.org.uk>
Date:	Tue, 17 Feb 2015 10:56:14 +0900
From:	Mark Brown <broonie@...nel.org>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	cw00.choi@...sung.com, myungjoo.ham@...sung.com,
	sameo@...ux.intel.com, lee.jones@...aro.org, lgirdwood@...il.com,
	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] extcon: arizona: Deobfuscate arizona_extcon_do_magic

On Mon, Feb 16, 2015 at 03:41:02PM +0000, Charles Keepax wrote:
> arizona_extcon_do_magic does not lend a lot of clarity to the purpose
> of the function, and as all the registers used are described in the
> datasheet there is no need to obfuscate the code. This patch renames the
> function to arizona_extcon_hp_clamp, as it controls clamping on the
> headphone output.

Probably worth noting that at the time the code was originally
implemented these registers weren't documented.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)