linux-kernel - Re: [PATCH 1/2] HID: i2c-hid: The interrupt should be level sensitive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 17 Feb 2015 13:24:18 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
cc:	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] HID: i2c-hid: The interrupt should be level
 sensitive

On Thu, 29 Jan 2015, Benjamin Tissoires wrote:

> > The Microsoft HID over I2C specification says two things regarding the
> > interrupt:
> > 
> >  1) The interrupt should be level sensitive
> >  2) The device keeps the interrupt asserted as long as it has more reports
> >     available.
> > 
> > We've seen that at least some Atmel and N-Trig panels keep the line low as
> > long as they have something to send. The current version of the driver only
> > detects the first edge but then fails to read rest of the reports (as the
> > line is still asserted).
> > 
> > Make the driver follow the specification and configure the HID interrupt to
> > be level sensitive.
> > 
> > The Windows HID over I2C driver also seems to do the same.
> > 
> > Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> > ---
> 
> FWIW, this one is
> Acked-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> 
> looks like we are going to drop 2/2, but this one is still valid.

Applied to for-3.20/upstream-fixes, thanks for your friendly ping in form 
of Ack :)

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/