linux-kernel - Re: [PATCH 03/45] headers_install.sh: enhance error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Feb 2015 14:17:51 +0100
From:	Michal Marek <mmarek@...e.cz>
To:	Mikko Rapeli <mikko.rapeli@....fi>, linux-kernel@...r.kernel.org
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Javier Barrio <javier.barrio.mart@...il.com>
Subject: Re: [PATCH 03/45] headers_install.sh: enhance error handling

On 2015-02-17 00:05, Mikko Rapeli wrote:
> Exit with error if using undefined variables or if any sub command fails
> with error return value. unidef needs special handling since but this can
> be done without the trap. Enables exaniming intermediate files if some
> commands failed.

The intermediate files are removed by your patch as well, aren't they?
Actually, I don't see any change in behavior after your patch.


> Signed-off-by: Mikko Rapeli <mikko.rapeli@....fi>
> ---
>  scripts/headers_install.sh | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/scripts/headers_install.sh b/scripts/headers_install.sh
> index fdebd66..072f7d3 100755
> --- a/scripts/headers_install.sh
> +++ b/scripts/headers_install.sh
> @@ -1,4 +1,7 @@
>  #!/bin/sh
> +set -e
> +set -u
> +#set -x

The commented-out statement should be removed.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/