linux-kernel - Re: [PATCH/RFC 2/2] regulator: da9210: Add optional interrupt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150217140110.GV9110@finisterre.sirena.org.uk>
Date:	Tue, 17 Feb 2015 23:01:10 +0900
From:	Mark Brown <broonie@...nel.org>
To:	Geert Uytterhoeven <geert+renesas@...der.be>
Cc:	Support Opensource <support.opensource@...semi.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Steve Twiss <stwiss.opensource@...semi.com>,
	linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH/RFC 2/2] regulator: da9210: Add optional interrupt support

On Tue, Feb 17, 2015 at 01:11:12PM +0100, Geert Uytterhoeven wrote:

>   - Does there exist any regulator notifier event that corresponds to
>     DA9210_E_VMAX?

What does that mean, I might be able to tell you?  I guess it might be
an over voltage event...

> +	error = regmap_read(chip->regmap, DA9210_REG_EVENT_B, &val);
> +	if (error < 0)
> +		goto error_i2c;

...

> +	if (val) {
> +		/* Clear all events */
> +		error = regmap_write(chip->regmap, DA9210_REG_EVENT_B, val);
> +		if (error < 0)
> +			goto error_i2c;
> +
> +		ret = IRQ_HANDLED;
> +	}

It's generally better to only acknowledge unmasked sources for
defensiveness and improved diagnostics.  Not super critical though.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)