linux-kernel - Re: [PATCH 4/4] ARM OMAP2+ GPMC: add bus children

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54E34D14.8080901@ti.com>
Date:	Tue, 17 Feb 2015 16:15:48 +0200
From:	Roger Quadros <rogerq@...com>
To:	Robert Abel <rabel@...-ec.uni-bielefeld.de>
CC:	<khilman@...prootsystems.com>, Tony Lindgren <tony@...mide.com>,
	<linux@....linux.org.uk>, <linux-omap@...r.kernel.org>,
	Linux Kernel Maling List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/4] ARM OMAP2+ GPMC: add bus children

On 17/02/15 15:57, Robert Abel wrote:
> Hi Roger,
> 
> On Tue, Feb 17, 2015 at 10:41 AM, Roger Quadros <rogerq@...com> wrote:>
>> Can we simply use only
>> of_platform_populate(child, NULL, NULL, &pdev->dev)
>>
>> That way we get rid of the if..else and let OF core take care of
>> creating buses or devices.
> 
> Surely, you mean
> 
>> of_platform_populate(child, of_default_bus_match_table, NULL, &pdev->dev);
> 
> ? If matches is NULL, we won't match any busses. Or did you mean to
> just replace the second conditional?

I was wondering if just one call to of_platform_populate() is sufficient.
so you probably need "of_default_bus_match_table" for matches.

> 
> I'll try that and see it works.
> 

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/