linux-kernel - Re: [PATCH 1/2] media/v4l2-ctrls: Always run s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Feb 2015 15:46:00 +0100
From:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:	Hans Verkuil <hans.verkuil@...co.com>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Jonathan Corbet <corbet@....net>,
	Arun Kumar K <arun.kk@...sung.com>,
	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Antti Palosaari <crope@....fi>,
	linux-media <linux-media@...r.kernel.org>,
	linux-doc@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Cc:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
Subject: Re: [PATCH 1/2] media/v4l2-ctrls: Always run s_ctrl on volatile ctrls

This is v3 of the patch.

I forgot to add it to the subject. I have marked v1 and v2 as
Superseded on patchwork

Thanks

On Tue, Feb 17, 2015 at 3:41 PM, Ricardo Ribalda Delgado
<ricardo.ribalda@...il.com> wrote:
> Volatile controls can change their value outside the v4l-ctrl framework.
> We should ignore the cached written value of the ctrl when evaluating if
> we should run s_ctrl.
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
> ---
>  drivers/media/v4l2-core/v4l2-ctrls.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c
> index 45c5b47..693a473 100644
> --- a/drivers/media/v4l2-core/v4l2-ctrls.c
> +++ b/drivers/media/v4l2-core/v4l2-ctrls.c
> @@ -1609,6 +1609,12 @@ static int cluster_changed(struct v4l2_ctrl *master)
>
>                 if (ctrl == NULL)
>                         continue;
> +
> +               if (ctrl->flags & V4L2_CTRL_FLAG_VOLATILE) {
> +                       changed = true;
> +                       continue;
> +               }
> +
>                 for (idx = 0; !ctrl_changed && idx < ctrl->elems; idx++)
>                         ctrl_changed = !ctrl->type_ops->equal(ctrl, idx,
>                                 ctrl->p_cur, ctrl->p_new);
> --
> 2.1.4
>



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/