linux-kernel - Re: [GIT PULL] please pull file-locking related changes for v3.20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150217142714.36ed9ddb@tlielax.poochiereds.net>
Date:	Tue, 17 Feb 2015 14:27:14 -0500
From:	Jeff Layton <jlayton@...chiereds.net>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	"J. Bruce Fields" <bfields@...ldses.org>,
	"Kirill A. Shutemov" <kirill@...temov.name>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@....de>,
	Dave Chinner <david@...morbit.com>,
	Sasha Levin <sasha.levin@...cle.com>
Subject: Re: [GIT PULL] please pull file-locking related changes for v3.20

On Tue, 17 Feb 2015 11:13:39 -0800
Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Tue, Feb 17, 2015 at 11:08 AM, J. Bruce Fields <bfields@...ldses.org> wrote:
> >
> > I agree that it's weird, but I think it's what we're stuck with.
> 
> And if by "weird" you mean "flock is really not a well-defined or sane
> interface", I'll agree with you.
> 
> That said, I'm not at all sure about the "we're stuck with it". We can
> improve the semantics without anybody noticing, because it's not like
> anybody could *depend* on the weaker semantics - they needed
> particular races and timings to hit anyway.
> 
>                           Linus

I'm not sure we want to make that change here and now though. That's
something that really ought to be approached a bit more carefully since
we might break some userland apps that depend on this (admittedly
strange) behavior.

What about this instead then?

- leave the "drop the spinlock" thing in place in flock_lock_file for
  v3.20

- change locks_remove_flock to just walk the list and delete any locks
  associated with the filp being closed

That should pretty closely mirror the behavior of v3.19.

Yes, that leaves the bug in place where you can end up with two locks
associated with the same filp, but that's the way it has worked now for
years. I'm leery of changing that behavior in the context of this set.

-- 
Jeff Layton <jlayton@...chiereds.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/