linux-kernel - Re: [PATCH v2 0/2] usb/gadget: independent registration of gadgets and gadget

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Feb 2015 22:24:40 +0200
From:	Ruslan Bilovol <ruslan.bilovol@...il.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	"Balbi, Felipe" <balbi@...com>,
	Krzysztof Opasiak <k.opasiak@...sung.com>,
	Peter Chen <peter.chen@...escale.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	Andrzej Pietrasiewicz <andrzej.p@...sung.com>
Subject: Re: [PATCH v2 0/2] usb/gadget: independent registration of gadgets
 and gadget

Hi Alan,

On Mon, Feb 16, 2015 at 1:04 AM, Alan Stern <stern@...land.harvard.edu> wrote:
> On Mon, 16 Feb 2015, Ruslan Bilovol wrote:
>
>> This patchset adds independent registration of gadgets
>> and gadget drivers to udc-core. This is very useful for
>> built-in modules into kernel case since it's possible
>> situation that gadget driver is probing at a time
>> when no gadgets are registered in udc-core.
>> In this case instead of silently failing without
>> of any attempt to recover, with independent registration
>> of gadgets and gadget drivers there is no matter
>> in which order gadgets and gadget drivers are
>> probed/registered.
>>
>> This patch has side-effect on gadget drivers that had
>> __init/__exit attributes on some paths like bind/unbind
>> and (since bind/unbind may happen at any time) should
>> not use them now. This is covered by second patch
>> (please let me know if I need to break it into separate
>> patches for each gadget driver)
>
> The two patches should be in the opposite order.  Otherwise someone
> might apply the first patch but not the second, and then the gadget
> drivers would crash when their bind/unbind routines were called at the
> wrong time.

Agree, this will be done in v3 patch set.

Best regards,
Ruslan

>
> Alan Stern
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/