linux-kernel - Re: [PATCH 2/2] drivers/core/of: Add symlink to device-tree from devices with an OF node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1424211372.21410.104.camel@kernel.crashing.org>
Date:	Wed, 18 Feb 2015 09:16:12 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Rob Herring <robherring2@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	Olof Johansson <olof@...om.net>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 2/2] drivers/core/of: Add symlink to device-tree from
 devices with an OF node

On Tue, 2015-02-17 at 07:09 -0800, Greg Kroah-Hartman wrote:
> > 
> > Doesn't this need sysfs documentation?
> 
> Yes it does.

Ok, will do.

> > > Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> > 
> > I don't mind applying, but this is Greg's code.
> > 
> > Rob
> > 
> > > ---
> > >  drivers/base/core.c | 8 ++++++++
> > >  1 file changed, 8 insertions(+)
> > >
> > > diff --git a/drivers/base/core.c b/drivers/base/core.c
> > > index 97e2baf..61ef574 100644
> > > --- a/drivers/base/core.c
> > > +++ b/drivers/base/core.c
> > > @@ -469,6 +469,7 @@ static int device_add_attrs(struct device *dev)
> > >  {
> > >         struct class *class = dev->class;
> > >         const struct device_type *type = dev->type;
> > > +       struct device_node *of_node;
> > >         int error;
> > >
> > >         if (class) {
> > > @@ -493,6 +494,13 @@ static int device_add_attrs(struct device *dev)
> > >                         goto err_remove_dev_groups;
> > >         }
> > >
> > > +       of_node = dev_of_node(dev);
> > > +       if (of_node) {
> > > +               error = sysfs_create_link(&dev->kobj, &of_node->kobj, "of_node");
> > > +               if (error)
> > > +                       dev_warn(dev, "Error %d creating of_node link\n", error);
> > > +       }
> 
> You don't clean up the link when the device is removed?

Hrm, I suppose I do :-) 

> And why do it here and not in device_add_class_symlinks() like all other
> devices do?

Well, device_add_class_symlinks() had "class" in the name so I
(incorrectly) assumed that was for class related stuff, but I see
that the parent pointer is there too. Also originally my patch was
adding an attribute and got turned into a symlink later. I'll move
it.

Cheers,
Ben.

> thanks,
> 
> greg k-h
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/