linux-kernel - Re: [PATCH 1/2] ocfs2: remove useless if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150217153057.c911fc895051343d69a78423@linux-foundation.org>
Date:	Tue, 17 Feb 2015 15:30:57 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Daeseok Youn <daeseok.youn@...il.com>
Cc:	mfasheh@...e.com, jlbec@...lplan.org, ocfs2-devel@....oracle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ocfs2: remove useless if statement

On Tue, 17 Feb 2015 16:13:50 +0900 Daeseok Youn <daeseok.youn@...il.com> wrote:

> The Local variable "i" in for loop is always less then
> O2CB_MAP_STABILIZE_COUNT.
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
> ---
>  fs/ocfs2/stack_o2cb.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ocfs2/stack_o2cb.c b/fs/ocfs2/stack_o2cb.c
> index 1724d43..813d726 100644
> --- a/fs/ocfs2/stack_o2cb.c
> +++ b/fs/ocfs2/stack_o2cb.c
> @@ -295,8 +295,8 @@ static int o2cb_cluster_check(void)
>  		set_bit(node_num, netmap);
>  		if (!memcmp(hbmap, netmap, sizeof(hbmap)))
>  			return 0;
> -		if (i < O2CB_MAP_STABILIZE_COUNT)
> -			msleep(1000);
> +
> +		msleep(1000);
>  	}

I assume the code was intended to do

	if (i < O2CB_MAP_STABILIZE_COUNT - 1)
		msleep(1000);

to avoid a pointless 1-second delay when the operation times out.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/