linux-kernel - Re: [PATCH] colons are invalid characters in netdev names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54E3D55B.6030304@mthode.org>
Date:	Tue, 17 Feb 2015 17:57:15 -0600
From:	Matthew Thode <mthode@...ode.org>
To:	Lino Sanfilippo <LinoSanfilippo@....de>, davem@...emloft.net
CC:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] colons are invalid characters in netdev names

On 02/17/2015 05:46 PM, Lino Sanfilippo wrote:
> On 18.02.2015 00:15, Matthew Thode wrote:
>> colons are used as a separator in netdev device lookup in dev_ioctl.c
>>
>> Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME
>>
>> Signed-off-by: Matthew Thode <mthode@...ode.org>
>> ---
>>  net/core/dev.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/core/dev.c b/net/core/dev.c
>> index d030575..e9b6d5a 100644
>> --- a/net/core/dev.c
>> +++ b/net/core/dev.c
>> @@ -942,7 +942,7 @@ bool dev_valid_name(const char *name)
>>  		return false;
>>  	if (strlen(name) >= IFNAMSIZ)
>>  		return false;
>> -	if (!strcmp(name, ".") || !strcmp(name, ".."))
>> +	if (!strcmp(name, ".") || !strcmp(name, "..") || !strcmp(name, ":"))
>>  		return false;
>>  
>>  	while (*name) {
>>
> 
> Hi,
> 
> that check should be done in the loop below, shouldn't it?
> 
> Regards,
> Lino
> 
You are correct,  should I resend a patch.  Not really sure the
procedure of updating a patchset sent to the ML.

-- 
Matthew Thode


Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)