lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 18 Feb 2015 13:08:26 +0100
From:	Thierry Reding <thierry.reding@...il.com>
To:	Gaetan Hug <ghug@...uct.be>
Cc:	linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/1] fix for pwm-mxs period divider computation

On Wed, Feb 18, 2015 at 09:18:55AM +0100, Gaetan Hug wrote:
> Hello Thierry,
> 
>    I found a bug in the pwm-mxs.c driver for the i.MX28 platform.
> 
>    The driver computes from the desired period which clock divider it
> should be using. This computation assumes that the link between the
> register value and the actual divider value is raising 2 to the power of
> the registry value.
> 
>     div = 1 << regvalue
> 
>    This is true only for the first 5 values out of 8. Next values are
> 64, 256 and, 1024.
>    This affects only the user only if he requests a period > 0.04369s.

Can you put this description into the commit message of the proper
patch, please?

Also, the subject should be in the following format:

	pwm: mxs: Fix period divider computation

Thanks,
Thierry

Content of type "application/pgp-signature" skipped

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ