linux-kernel - Re: [PATCH] rtc: ds1685: fix ds1685_rtc_alarm_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54E4981F.7050309@gentoo.org>
Date:	Wed, 18 Feb 2015 08:48:15 -0500
From:	Joshua Kinard <kumba@...too.org>
To:	Arnd Bergmann <arnd@...db.de>,
	Andrew Morton <akpm@...ux-foundation.org>
CC:	Ralf Baechle <ralf@...ux-mips.org>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com
Subject: Re: [PATCH] rtc: ds1685: fix ds1685_rtc_alarm_irq_enable build error

On 02/18/2015 05:42, Arnd Bergmann wrote:
> The newly added ds1685 driver causes a build error in linux-next
> when enabled without CONFIG_RTC_INTF_DEV:
> 
> drivers/rtc/rtc-ds1685.c:919:22: error: 'ds1685_rtc_alarm_irq_enable' undeclared here (not in a function)
>   .alarm_irq_enable = ds1685_rtc_alarm_irq_enable,
> 
> Apparently the driver was incorrectly changed to reflect the interface
> change from 16380c153a69c ("RTC: Convert rtc drivers to use the
> alarm_irq_enable method"), which removed the respective #ifdef
> from all other rtc drivers.
> 
> This does the same change that was merged for the other drivers
> before and removes the #ifdef, allowing the interrupts to be
> enabled through the in-kernel rtc interface independent of the
> existence of /dev/rtc.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: aaaf5fbf56f ("rtc: add driver for DS1685 family of real time clocks")

I probably copied that #define out of another RTC driver before the change was
made, then discovered the compile failure later on and just didn't read enough
to understand the change, thus only fixing it enough to compile again.

Thanks for catching it!

Acked-by: Joshua Kinard <kumba@...too.org>

> ---
> For some reason, this error never showed up in linux-next, but it
> does now that the driver has made it into mainline, while doing ARM
> randconfig testing.
> 
> diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c
> index 8c3bfcb115b7..5dc1ef9d0008 100644
> --- a/drivers/rtc/rtc-ds1685.c
> +++ b/drivers/rtc/rtc-ds1685.c
> @@ -528,7 +528,6 @@ ds1685_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
>  /* ----------------------------------------------------------------------- */
>  /* /dev/rtcX Interface functions */
>  
> -#ifdef CONFIG_RTC_INTF_DEV
>  /**
>   * ds1685_rtc_alarm_irq_enable - replaces ioctl() RTC_AIE on/off.
>   * @dev: pointer to device structure.
> @@ -557,7 +556,6 @@ ds1685_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
>  
>  	return 0;
>  }
> -#endif
>  /* ----------------------------------------------------------------------- */
>  
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/