linux-kernel - Re: [PATCH] livepatch: remove extern specifier from header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54E4A957.3050705@hitachi.com>
Date:	Thu, 19 Feb 2015 00:01:43 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	Miroslav Benes <mbenes@...e.cz>
Cc:	jpoimboe@...hat.com, sjenning@...hat.com, jkosina@...e.cz,
	vojtech@...e.cz, pmladek@...e.cz, live-patching@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] livepatch: remove extern specifier from header files

(2015/02/18 23:21), Miroslav Benes wrote:
> Storage-class specifier 'extern' is redundant in front of the function
> declaration. According to the C specification it has the same meaning as
> if not present at all. So remove it.
> 
> Signed-off-by: Miroslav Benes <mbenes@...e.cz>

Looks good to me.

Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>

> ---
>  arch/x86/include/asm/livepatch.h | 4 ++--
>  include/linux/livepatch.h        | 8 ++++----
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/x86/include/asm/livepatch.h b/arch/x86/include/asm/livepatch.h
> index a455a53..2d29197 100644
> --- a/arch/x86/include/asm/livepatch.h
> +++ b/arch/x86/include/asm/livepatch.h
> @@ -32,8 +32,8 @@ static inline int klp_check_compiler_support(void)
>  #endif
>  	return 0;
>  }
> -extern int klp_write_module_reloc(struct module *mod, unsigned long type,
> -				  unsigned long loc, unsigned long value);
> +int klp_write_module_reloc(struct module *mod, unsigned long type,
> +			   unsigned long loc, unsigned long value);
>  
>  static inline void klp_arch_set_pc(struct pt_regs *regs, unsigned long ip)
>  {
> diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h
> index 95023fd..ee6dbb3 100644
> --- a/include/linux/livepatch.h
> +++ b/include/linux/livepatch.h
> @@ -123,10 +123,10 @@ struct klp_patch {
>  	enum klp_state state;
>  };
>  
> -extern int klp_register_patch(struct klp_patch *);
> -extern int klp_unregister_patch(struct klp_patch *);
> -extern int klp_enable_patch(struct klp_patch *);
> -extern int klp_disable_patch(struct klp_patch *);
> +int klp_register_patch(struct klp_patch *);
> +int klp_unregister_patch(struct klp_patch *);
> +int klp_enable_patch(struct klp_patch *);
> +int klp_disable_patch(struct klp_patch *);
>  
>  #endif /* CONFIG_LIVEPATCH */
>  
> 


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@...achi.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/