linux-kernel - [tip:perf/core] perf symbols: Ignore mapping symbols on aarch64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-4886f2ca19f6ff22ebfbe8e78c79c699e572b89f@git.kernel.org>
Date:	Wed, 18 Feb 2015 10:26:02 -0800
From:	tip-bot for Victor Kamensky <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	avi@...udius-systems.com, will.deacon@....com, dsahern@...il.com,
	hpa@...or.com, a.p.zijlstra@...llo.nl, anton@...ba.org,
	paulus@...ba.org, tglx@...utronix.de, adrian.hunter@...el.com,
	masami.hiramatsu.pt@...achi.com, acme@...hat.com,
	victor.kamensky@...aro.org, linux@....linux.org.uk,
	Dave.Martin@....com, jolsa@...hat.com, mingo@...nel.org,
	namhyung@...nel.org, linux-kernel@...r.kernel.org
Subject: [tip:perf/core] perf symbols: Ignore mapping symbols on aarch64

Commit-ID:  4886f2ca19f6ff22ebfbe8e78c79c699e572b89f
Gitweb:     http://git.kernel.org/tip/4886f2ca19f6ff22ebfbe8e78c79c699e572b89f
Author:     Victor Kamensky <victor.kamensky@...aro.org>
AuthorDate: Mon, 26 Jan 2015 22:34:01 -0800
Committer:  Arnaldo Carvalho de Melo <acme@...hat.com>
CommitDate: Fri, 6 Feb 2015 11:46:36 +0100

perf symbols: Ignore mapping symbols on aarch64

Aarch64 ELF files use mapping symbols with special names $x, $d
to identify regions of Aarch64 code (see Aarch64 ELF ABI - "ARM
IHI 0056B", section "4.5.4 Mapping symbols").

The patch filters out these symbols at load time, similar to
"696b97a perf symbols: Ignore mapping symbols on ARM" changes
done for ARM before V8.

Also added handling of mapping symbols that has format
"$d.<any>" and similar for both cases.

Note we are not making difference between EM_ARM and
EM_AARCH64 mapping symbols instead code handles superset
of both.

Signed-off-by: Victor Kamensky <victor.kamensky@...aro.org>
Acked-by: Namhyung Kim <namhyung@...nel.org>
Acked-by: Will Deacon <will.deacon@....com>
Cc: Adrian Hunter <adrian.hunter@...el.com>
Cc: Anton Blanchard <anton@...ba.org>
Cc: Avi Kivity <avi@...udius-systems.com>
Cc: Dave Martin <Dave.Martin@....com>
Cc: David Ahern <dsahern@...il.com>
Cc: Jiri Olsa <jolsa@...hat.com>
Cc: linux-arm-kernel@...ts.infradead.org
Cc: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Cc: Paul Mackerras <paulus@...ba.org>
Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc: Russell King <linux@....linux.org.uk>
Link: http://lkml.kernel.org/r/1422340442-4673-2-git-send-email-victor.kamensky@linaro.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
---
 tools/perf/util/symbol-elf.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
index b24f9d8..225eb73 100644
--- a/tools/perf/util/symbol-elf.c
+++ b/tools/perf/util/symbol-elf.c
@@ -859,10 +859,9 @@ int dso__load_sym(struct dso *dso, struct map *map,
 		/* Reject ARM ELF "mapping symbols": these aren't unique and
 		 * don't identify functions, so will confuse the profile
 		 * output: */
-		if (ehdr.e_machine == EM_ARM) {
-			if (!strcmp(elf_name, "$a") ||
-			    !strcmp(elf_name, "$d") ||
-			    !strcmp(elf_name, "$t"))
+		if (ehdr.e_machine == EM_ARM || ehdr.e_machine == EM_AARCH64) {
+			if (elf_name[0] == '$' && strchr("adtx", elf_name[1])
+			    && (elf_name[2] == '\0' || elf_name[2] == '.'))
 				continue;
 		}
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/