linux-kernel - Re: [PATCH 3.2 082/152] virtio: use dev_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871tlnu8uk.fsf@rustcorp.com.au>
Date:	Wed, 18 Feb 2015 15:14:35 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	akpm@...ux-foundation.org, "Michael S. Tsirkin" <mst@...hat.com>,
	Wanlong Gao <gaowanlong@...fujitsu.com>
Subject: Re: [PATCH 3.2 082/152] virtio: use dev_to_virtio wrapper in virtio

Ben Hutchings <ben@...adent.org.uk> writes:
> On Tue, 2015-02-17 at 15:56 +1030, Rusty Russell wrote:
>> Ben Hutchings <ben@...adent.org.uk> writes:
>> > 3.2.67-rc1 review patch.  If anyone has any objections, please let me know.
>> 
>> Ben, what are your criteria for putting patches into 3.2?
>> 
>> This patch is a trivial cleanup.  It doesn't fix anything, but it does
>> add some churn.
>
> It fixes the definition of dev_to_virtio().

Argh, sorry I should have caught that.  The commit message didn't
actually mention that it fixed anything (and I took it).  :(

>> I can see that 083 and 084 follow this, but 083 needed a backport
>> anyway.
>
> Patch 083 "virtio_pci: defer kfree until release callback" uses
> dev_to_virtio(_d) which would expand to a syntax error without this.
>
>> And it wasn't an issue we saw in Real Life (device removal
>> is rare), so it wasn't CC: stable.
>> 
>> 084 was a comment addition.  Backporting that just seems weird.
>
> Nevertheless, it had 'cc: stable' and is obviously harmless.

Ah I see, you stripped the cc:stable in your version.  The original
did indeed have CC:stable, which is MST's perogative...

Thanks for the explanation,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/