| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20150218132715.be18865751a83820f635f04e@linux-foundation.org> Date: Wed, 18 Feb 2015 13:27:15 -0800 From: Andrew Morton <akpm@...ux-foundation.org> To: "Wang, Yalin" <Yalin.Wang@...ymobile.com> Cc: "'viro@...iv.linux.org.uk'" <viro@...iv.linux.org.uk>, "'linux-fsdevel@...r.kernel.org'" <linux-fsdevel@...r.kernel.org>, "'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>, "Gao, Neil" <Neil.Gao@...ymobile.com> Subject: Re: [RFC V3] test bit before clear files_struct bits On Sun, 15 Feb 2015 16:27:27 +0800 "Wang, Yalin" <Yalin.Wang@...ymobile.com> wrote: > +/* > + * __*_if_need version is used in cases that you don't want write a bit which > + * have been set / clear, to avoid dirty cacheline. > + */ > +static inline void __set_bit_if_need(int nr, volatile unsigned long *addr) "if_need" is gramatically incorrect - it should be "if_needed". And __set_bit_if_needed is too long. But I can't think of anything shorter, unless we do something lame like __set_bit2(). __set_bit_if_clear() isn't too bad? Also, your changelog still doesn't include the results of the quantitative testing which you performed to demonstrate that these code sites will benefit from this conversion. Please copy all that info into the changelog! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists