linux-kernel - Re: [PATCH v2 0/2] x86: loadflags cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 18 Feb 2015 23:06:50 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Alexander Kuleshov <kuleshovmail@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Martin Mares <mj@....cz>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] x86: loadflags cleanups


* Alexander Kuleshov <kuleshovmail@...il.com> wrote:

> There are a couple macros in the arch/x86/include/uapi/asm/bootparam.h
> for checking loadflags bits. Let's use it instead of shifting bits
> 
> Alexander Kuleshov (2):
>   x86: use already defined KEEP_SEGMENTS macro from bootparam.h
>   x86/boot: use already defined KEEP_SEGMENTS macro in head_{32,64}.S
> 
>  arch/x86/boot/compressed/head_32.S | 5 +++--
>  arch/x86/boot/compressed/head_64.S | 3 ++-
>  arch/x86/kernel/head_32.S          | 7 ++++---
>  3 files changed, 9 insertions(+), 6 deletions(-)

I think a single patch would be perfectly fine for a 
cleanup that does the same thing in three files.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/