linux-kernel - Re: [PATCH] HID: wacom: do not directly use input_mt_report_pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1502182343360.28769@pobox.suse.cz>
Date:	Wed, 18 Feb 2015 23:43:52 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Benjamin Tissoires <benjamin.tissoires@...il.com>
cc:	Ping Cheng <pinglinux@...il.com>,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Jason Gerecke <killertofu@...il.com>,
	linux-input <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: wacom: do not directly use
 input_mt_report_pointer_emulation

On Tue, 17 Feb 2015, Benjamin Tissoires wrote:

> On Tue, Feb 17, 2015 at 5:36 PM, Ping Cheng <pinglinux@...il.com> wrote:
> > On Tue, Feb 17, 2015 at 11:19 AM, Benjamin Tissoires
> > <benjamin.tissoires@...hat.com> wrote:
> >> input_mt_sync_frame() calls input_mt_report_pointer_emulation() and do
> >> some internal steps required to keep in sync the state of the touch within
> >> the various reports.
> >>
> >> Given that we use input_mt_assign_slot() in this driver, it is better to
> >> use input_mt_sync_frame().
> >
> > It is sensible to me, except I think you meant input_mt_slot() instead
> > of input_mt_assign_slot().
> 
> Hehe, I should have actually checked the call. I meant
> input_mt_get_slot_by_key().
> 
> >
> >> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> >
> > Reviewed-by: Ping Cheng <pingc@...om.com>

Applied (with adjusted changelog).

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/