linux-kernel - Re: [GIT PULL] Fix mcelog regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150218064135.GA9832@gmail.com>
Date:	Wed, 18 Feb 2015 07:41:35 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	"Luck, Tony" <tony.luck@...el.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org,
	Borislav Petkov <bp@...e.de>
Subject: Re: [GIT PULL] Fix mcelog regression


* Luck, Tony <tony.luck@...el.com> wrote:

> Sorry for bypassing normal channels, but this looks like 
> a trivial regression fix to me, but I'm getting pushback 
> from my co-maintainer and from Ingo.
> 
>   1. This used to work
>   2. Now it doesn't
>   3. People have complained
> 
> Previous threads:
>   https://lkml.org/lkml/2015/1/30/641
>   https://lkml.org/lkml/2015/2/11/437

So this fix is perfectly OK to me. The primary thing I 
objected to (which objection you did not quote!!), was the 
initial approach, the ugly vendor-specific switch you 
added:

    https://lkml.org/lkml/2015/2/9/237

The latest replacement commit you added looks clean - and 
/dev/mcelog is certainly a legacy we have to keep.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/