linux-kernel - Re: [PATCH v5 59/61] dmaengine: Add a warning for drivers not using the generic slave caps retrieval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOh2x=n1SC+s3hyFaOpREwVuzvqDUwb5vsTBN0As+O2h6eXbMw@mail.gmail.com>
Date:	Thu, 19 Feb 2015 15:57:27 +0800
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	bloften80@...il.com, jdelvare@...e.de
Cc:	Vinod Koul <vinod.koul@...el.com>, dmaengine@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Antoine Ténart <antoine@...e-electrons.com>,
	Russell King <linux@....linux.org.uk>,
	Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v5 59/61] dmaengine: Add a warning for drivers not using
 the generic slave caps retrieval

On Mon, Nov 17, 2014 at 9:42 PM, Maxime Ripard
<maxime.ripard@...e-electrons.com> wrote:
> For the slave caps retrieval to be really useful, most drivers need to
> implement it.
>
> Hence, we need to be slightly more aggressive, and trigger a warning at
> registration time for drivers that don't fill their caps infos in order to
> encourage them to implement it.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> ---
>  drivers/dma/dmaengine.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
> index 98e9431f85ec..300c8cd2786c 100644
> --- a/drivers/dma/dmaengine.c
> +++ b/drivers/dma/dmaengine.c
> @@ -827,6 +827,9 @@ int dma_async_device_register(struct dma_device *device)
>         BUG_ON(!device->device_issue_pending);
>         BUG_ON(!device->dev);
>
> +       WARN(dma_has_cap(DMA_SLAVE, device->cap_mask) && !device->directions,
> +            "this driver doesn't support generic slave capabilities reporting\n");
> +
>         /* note: this only matters in the
>          * CONFIG_ASYNC_TX_ENABLE_CHANNEL_SWITCH=n case
>          */

Probably you need to fix this ?

https://bugzilla.kernel.org/show_bug.cgi?id=90801
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/