linux-kernel - Re: [PATCH 5/6] ASoC: samsung: Extend Snow driver to support max98089

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150219094425.GB3198@finisterre.sirena.org.uk>
Date:	Thu, 19 Feb 2015 18:44:25 +0900
From:	Mark Brown <broonie@...nel.org>
To:	Andreas Färber <afaerber@...e.de>
Cc:	Sangbeom Kim <sbkim73@...sung.com>, alsa-devel@...a-project.org,
	linux-samsung-soc@...r.kernel.org,
	Liam Girdwood <lgirdwood@...il.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org,
	Vincent Palatin <vpalatin@...omium.org>,
	Doug Anderson <dianders@...omium.org>,
	Javier Martinez Canillas <javier.martinez@...labora.co.uk>,
	Tomasz Figa <tomasz.figa@...il.com>,
	Kukjin Kim <kgene@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>
Subject: Re: [PATCH 5/6] ASoC: samsung: Extend Snow driver to support max98089

On Wed, Feb 18, 2015 at 07:25:58PM +0100, Andreas Färber wrote:

>  static const struct of_device_id snow_of_match[] = {
> +	{ .compatible = "google,snow-audio-max98089", },
>  	{ .compatible = "google,snow-audio-max98090", },
>  	{ .compatible = "google,snow-audio-max98091", },
>  	{ .compatible = "google,snow-audio-max98095", },

Since we completely ignore the CODEC in the property might it not be
better to just add a plain old snow-audio compatible and bind to that,
that way we don't need these driver updates?  Just the "snow" bit should
be enough to know it's one of this class of machines.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)