linux-kernel - Re: [PATCH] x86/intel/quark: fix ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54E5B6FA.7030807@nexus-software.ie>
Date:	Thu, 19 Feb 2015 10:12:10 +0000
From:	Bryan O'Donoghue <pure.logic@...us-software.ie>
To:	kbuild test robot <fengguang.wu@...el.com>
CC:	kbuild-all@...org, Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Andy Shevchenko <andy.schevchenko@...il.com>,
	"Ong, Boon Leong" <boon.leong.ong@...el.com>,
	Darren Hart <dvhart@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/intel/quark: fix ptr_ret.cocci warnings

On 19/02/15 08:14, kbuild test robot wrote:
> arch/x86/platform/intel-quark/imr.c:280:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
>
>   Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> CC: Bryan O'Donoghue <pure.logic@...us-software.ie>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
>
>   imr.c |    5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> --- a/arch/x86/platform/intel-quark/imr.c
> +++ b/arch/x86/platform/intel-quark/imr.c
> @@ -277,10 +277,7 @@ static int imr_debugfs_register(struct i
>   {
>   	idev->file = debugfs_create_file("imr_state", S_IFREG | S_IRUGO, NULL,
>   					 idev, &imr_state_ops);
> -	if (IS_ERR(idev->file))
> -		return PTR_ERR(idev->file);
> -
> -	return 0;
> +	return PTR_ERR_OR_ZERO(idev->file);
>   }
>
>   /**
>

This is a reasonable change.

ACK
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/