linux-kernel - Re: [PATCH] x86/intel/quark: fix simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54E5BB87.3020206@nexus-software.ie>
Date:	Thu, 19 Feb 2015 10:31:35 +0000
From:	Bryan O'Donoghue <pure.logic@...us-software.ie>
To:	Ingo Molnar <mingo@...nel.org>
CC:	kbuild test robot <fengguang.wu@...el.com>, kbuild-all@...org,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Andy Shevchenko <andy.schevchenko@...il.com>,
	"Ong, Boon Leong" <boon.leong.ong@...el.com>,
	Darren Hart <dvhart@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/intel/quark: fix simple_return.cocci warnings

On 19/02/15 10:25, Ingo Molnar wrote:

>>> -	ret = iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ,
>>> +	return iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ,
>>>   				reg++, &imr->wmask);
>>> -	if (ret)
>>> -		return ret;
>>> -
>>> -	return 0;
>>>   }
>>>
>>>   /**
>>>
>>
>> This flow was a change asked for and supplied in review
>> feedback for Andy Shevchenko so NAK to this patch.
>
> But this pattern:
>
> 	if (ret)
> 		return ret;
>
> 	return 0;
>
> makes very little sense. Why is it done?
>
> Thanks,
>
> 	Ingo

Feedback at review was that it's more consistent with the code that 
comes before.

So I changed it from

return iosf_mbi_read

to

ret = iosf_mbi_read

if (ret)
	return ret;
return 0;

as a result. I'm OK with the change suggested by the script if Andy (who 
requested the change) is.

--
Bryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/