linux-kernel - Re: [PATCH] mtd: pxa3xx-nand: handle PIO in threaded interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 19 Feb 2015 12:17:15 +0100
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Robert Jarzmik <robert.jarzmik@...e.fr>
Cc:	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: pxa3xx-nand: handle PIO in threaded interrupt

On Wed, Feb 18, 2015 at 06:16:17PM +0100, Robert Jarzmik wrote:
> >> @@ -1672,7 +1688,8 @@ static int alloc_nand_resource(struct platform_device *pdev)
> >>  	/* initialize all interrupts to be disabled */
> >>  	disable_int(info, NDSR_MASK);
> >>  
> >> -	ret = request_irq(irq, pxa3xx_nand_irq, 0, pdev->name, info);
> >> +	ret = request_threaded_irq(irq, pxa3xx_nand_irq,
> >> +				   pxa3xx_nand_irq_thread, 0, pdev->name, info);
> >
> > Using IRQF_ONESHOT would allow you not to do the interrupt enable /
> > disable dance.
>
> Yes, that's a very good point. Would your Tested-by still hold with
> this change ?

Yep, I actually tested it before suggesting it.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)