linux-kernel - [tip:x86/platform] x86/intel/quark: Fix simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 19 Feb 2015 03:31:49 -0800
From:	tip-bot for Fengguang Wu <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, mingo@...nel.org,
	dvhart@...ux.intel.com, tglx@...utronix.de, hpa@...or.com,
	andy.schevchenko@...il.com, fengguang.wu@...el.com,
	pure.logic@...us-software.ie, boon.leong.ong@...el.com
Subject: [tip:x86/platform] x86/intel/quark:
  Fix simple_return.cocci warnings

Commit-ID:  c11a25f443e9bee06fe302b6a78ff44dac554036
Gitweb:     http://git.kernel.org/tip/c11a25f443e9bee06fe302b6a78ff44dac554036
Author:     Fengguang Wu <fengguang.wu@...el.com>
AuthorDate: Thu, 19 Feb 2015 16:14:32 +0800
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Thu, 19 Feb 2015 10:00:55 +0100

x86/intel/quark: Fix simple_return.cocci warnings

arch/x86/platform/intel-quark/imr.c:129:1-4: WARNING: end returns can be simpified

 Simplify a trivial if-return sequence.  Possibly combine with a preceding function call.

Generated by: scripts/coccinelle/misc/simple_return.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
Cc: Andy Shevchenko <andy.schevchenko@...il.com>
Cc: Ong, Boon Leong <boon.leong.ong@...el.com>
Cc: Bryan O'Donoghue <pure.logic@...us-software.ie>
Cc: Darren Hart <dvhart@...ux.intel.com>
Cc: kbuild-all@...org
Link: http://lkml.kernel.org/r/20150219081432.GA21996@waimea
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/platform/intel-quark/imr.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/x86/platform/intel-quark/imr.c b/arch/x86/platform/intel-quark/imr.c
index 60c01eb..0ee619f 100644
--- a/arch/x86/platform/intel-quark/imr.c
+++ b/arch/x86/platform/intel-quark/imr.c
@@ -126,12 +126,8 @@ static int imr_read(struct imr_device *idev, u32 imr_id, struct imr_regs *imr)
 	if (ret)
 		return ret;
 
-	ret = iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ,
+	return iosf_mbi_read(QRK_MBI_UNIT_MM, QRK_MBI_MM_READ,
 				reg++, &imr->wmask);
-	if (ret)
-		return ret;
-
-	return 0;
 }
 
 /**
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/