linux-kernel - Re: [PATCH 2/2] regmap: Add range check in _regmap_raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150219115557.GA1581@finisterre.sirena.org.uk>
Date:	Thu, 19 Feb 2015 20:55:57 +0900
From:	Mark Brown <broonie@...nel.org>
To:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] regmap: Add range check in _regmap_raw_write()

On Thu, Feb 19, 2015 at 11:11:58AM +0000, Srinivas Kandagatla wrote:
> On 19/02/15 10:31, Mark Brown wrote:

> >Your changelog doesn't correspond to what the code is actually doing
> >here...  what you're actually doing here is replacing an open coding of
> >regmap_writeable() with calls to the function.

> Only reason for me to send this patch was that fact that _regmap_raw_write()
> also suffers from same issue as _regmap_raw_read(), which is "access beyond
> max_register".

> Should I drop this patch?
> Or
> Adding similar check of max_register before the writing makes sense?

No, please go and reread your patch - neither your description above nor
the changelog match up with what it's actually doing.  It looks like a
perfectly sensible patch, it just doesn't do what you're saying it does.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)