linux-kernel - Re: [Xen-devel] [PATCH 10/10] xen/blkfront: use work queue to fast blkif interrupt return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54E61488.2020402@cantab.net>
Date:	Thu, 19 Feb 2015 16:51:20 +0000
From:	David Vrabel <dvrabel@...tab.net>
To:	Bob Liu <bob.liu@...cle.com>, xen-devel@...ts.xen.org
CC:	hch@...radead.org, felipe.franciosi@...rix.com,
	linux-kernel@...r.kernel.org, axboe@...com,
	david.vrabel@...rix.com, avanzini.arianna@...il.com,
	roger.pau@...rix.com
Subject: Re: [Xen-devel] [PATCH 10/10] xen/blkfront: use work queue to fast
 blkif interrupt return



On 15/02/2015 08:19, Bob Liu wrote:
> Move the request complete logic out of blkif_interrupt() to a work queue,
> after that we can replace 'spin_lock_irq' with 'spin_lock' so that irq won't
> be disabled too long in blk_mq_queue_rq().

I think using a threaded interrupt (like scsifront) is better than work. 
  Also, this seems orthogonal to the multiqueue support.  Is it a useful 
bug fix on its own?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/