linux-kernel - Re: [PATCH v5 2/3] mm: cma: allocation trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Feb 2015 20:38:25 +0300
From:	Stefan Strogin <s.strogin@...tner.samsung.com>
To:	Sasha Levin <sasha.levin@...cle.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Cc:	iamjoonsoo.kim@....com, m.szyprowski@...sung.com,
	akpm@...ux-foundation.org, lauraa@...eaurora.org
Subject: Re: [PATCH v5 2/3] mm: cma: allocation trigger

Hi,

On 13/02/15 01:26, Sasha Levin wrote:
> Provides a userspace interface to trigger a CMA allocation.
> 
> Usage:
> 
> 	echo [pages] > alloc
> 
> This would provide testing/fuzzing access to the CMA allocation paths.
> 
> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>
> ---
>  mm/cma.c       |    6 ++++++
>  mm/cma.h       |    4 ++++
>  mm/cma_debug.c |   56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++--
>  3 files changed, 64 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/cma_debug.c b/mm/cma_debug.c
> index 3a25413..5bd6863 100644
> --- a/mm/cma_debug.c
> +++ b/mm/cma_debug.c
> @@ -23,8 +32,48 @@ static int cma_debugfs_get(void *data, u64 *val)
>  
>  DEFINE_SIMPLE_ATTRIBUTE(cma_debugfs_fops, cma_debugfs_get, NULL, "%llu\n");
>  
> -static void cma_debugfs_add_one(struct cma *cma, int idx)
> +static void cma_add_to_cma_mem_list(struct cma *cma, struct cma_mem *mem)
> +{
> +	spin_lock(&cma->mem_head_lock);
> +	hlist_add_head(&mem->node, &cma->mem_head);
> +	spin_unlock(&cma->mem_head_lock);
> +}
> +
> +static int cma_alloc_mem(struct cma *cma, int count)
> +{
> +	struct cma_mem *mem;
> +	struct page *p;
> +
> +	mem = kzalloc(sizeof(*mem), GFP_KERNEL);
> +	if (!mem) 
> +		return -ENOMEM;
> +
> +	p = cma_alloc(cma, count, CONFIG_CMA_ALIGNMENT);

If CONFIG_DMA_CMA (and therefore CONFIG_CMA_ALIGNMENT) isn't configured
then building fails.
> mm/cma_debug.c: In function ‘cma_alloc_mem’:
> mm/cma_debug.c:223:28: error: ‘CONFIG_CMA_ALIGNMENT’ undeclared (first use in this function)
>   p = cma_alloc(cma, count, CONFIG_CMA_ALIGNMENT);
>                             ^

Also, could you please fix the whitespace errors in your patches?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/