linux-kernel - Re: [PATCH 0/2] perf/x86: Add ability to sample TSC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150219191321.GA12008@gmail.com>
Date:	Thu, 19 Feb 2015 20:13:21 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	linux-kernel@...r.kernel.org, David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...hat.com>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Stephane Eranian <eranian@...gle.com>,
	John Stultz <john.stultz@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Pawel Moll <pawel.moll@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 0/2] perf/x86: Add ability to sample TSC


* Adrian Hunter <adrian.hunter@...el.com> wrote:

> > I suspect you're talking about something else entirely; 
> > your changelogs are inadequate for they tell ntohing of 
> > your usecase and have me guessing. Don't do that.
> 
> Sorry. I did mention Intel PT in patch 2, but I basically 
> assumed the need to synchronize events with other time 
> sources was understood.

Written down, slightly repetitive walk-throughs from first 
concepts to implementation that don't assume too much 
context are very useful to us slightly overworked 
maintainers with an attention span of a slightly retarded 
golden retriever. (Make the story interesting and mix in a 
few jokes and you've got our attention for sure!)

So please do explain verbosely, especially if a review 
discussion turns somewhat discordant, it's a useful tool.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/