linux-kernel - Re: [PATCH] dmaengine: qcom_bam_dma: fix wrong register offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54E6F20A.60005@codeaurora.org>
Date:	Fri, 20 Feb 2015 14:06:26 +0530
From:	Archit Taneja <architt@...eaurora.org>
To:	Stanimir Varbanov <svarbanov@...sol.com>,
	Vinod Koul <vinod.koul@...el.com>
CC:	linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, Andy Gross <agross@...eaurora.org>,
	Stephen Boyd <sboyd@...eaurora.org>
Subject: Re: [PATCH] dmaengine: qcom_bam_dma: fix wrong register offsets



On 02/19/2015 10:15 PM, Stanimir Varbanov wrote:
> The commit fb93f520e (dmaengine: qcom_bam_dma: Generalize BAM
> register offset calculations) wrongly populated base offsets
> for event registers for bam v1.4.
>
> Signed-off-by: Stanimir Varbanov <svarbanov@...sol.com>
> ---
>   drivers/dma/qcom_bam_dma.c |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/qcom_bam_dma.c b/drivers/dma/qcom_bam_dma.c
> index debe106..95b7668 100644
> --- a/drivers/dma/qcom_bam_dma.c
> +++ b/drivers/dma/qcom_bam_dma.c
> @@ -162,9 +162,9 @@ static const struct reg_offset_data bam_v1_4_reg_info[] = {
>   	[BAM_P_IRQ_STTS]	= { 0x1010, 0x1000, 0x00, 0x00 },
>   	[BAM_P_IRQ_CLR]		= { 0x1014, 0x1000, 0x00, 0x00 },
>   	[BAM_P_IRQ_EN]		= { 0x1018, 0x1000, 0x00, 0x00 },
> -	[BAM_P_EVNT_DEST_ADDR]	= { 0x102C, 0x00, 0x1000, 0x00 },
> -	[BAM_P_EVNT_REG]	= { 0x1018, 0x00, 0x1000, 0x00 },
> -	[BAM_P_SW_OFSTS]	= { 0x1000, 0x00, 0x1000, 0x00 },
> +	[BAM_P_EVNT_DEST_ADDR]	= { 0x182C, 0x00, 0x1000, 0x00 },
> +	[BAM_P_EVNT_REG]	= { 0x1818, 0x00, 0x1000, 0x00 },
> +	[BAM_P_SW_OFSTS]	= { 0x1800, 0x00, 0x1000, 0x00 },
>   	[BAM_P_DATA_FIFO_ADDR]	= { 0x1824, 0x00, 0x1000, 0x00 },
>   	[BAM_P_DESC_FIFO_ADDR]	= { 0x181C, 0x00, 0x1000, 0x00 },
>   	[BAM_P_EVNT_GEN_TRSHLD]	= { 0x1828, 0x00, 0x1000, 0x00 },
>

Didn't know how this crept in. Apologies for the inconvenience!

Reviewed-by: Archit Taneja <architt@...eaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/