linux-kernel - Re: [PATCH] fbdev: via/via

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54E72803.5080204@ti.com>
Date:	Fri, 20 Feb 2015 14:26:43 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Lad Prabhakar <prabhakar.csengg@...il.com>
CC:	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	<linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fbdev: via/via_clock: fix sparse warning

On 05/02/15 14:54, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
> 
> this patch fixes following sparse warning:
> 
> via_clock.c:33:12: warning: symbol 'via_slap' was not declared. Should it be static?
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>
> ---
>  Found this issue on linux-next (gcc  version 4.9.2,
>  sparse version  0.4.5-rc1)and applies on top linux-next.
> 
>  drivers/video/fbdev/via/via_clock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/via/via_clock.c b/drivers/video/fbdev/via/via_clock.c
> index db1e392..bf269fa 100644
> --- a/drivers/video/fbdev/via/via_clock.c
> +++ b/drivers/video/fbdev/via/via_clock.c
> @@ -30,7 +30,7 @@
>  #include "global.h"
>  #include "debug.h"
>  
> -const char *via_slap = "Please slap VIA Technologies to motivate them "
> +static const char *via_slap = "Please slap VIA Technologies to motivate them "
>  	"releasing full documentation for your platform!\n";
>  
>  static inline u32 cle266_encode_pll(struct via_pll_config pll)
> 

Thanks, queued for 3.21.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)