linux-kernel - Re: [RFT PATCH v2 2/2] compal-laptop: Check return value of power_supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <1424437922.1870.1.camel@AMDC1943>
Date:	Fri, 20 Feb 2015 14:12:02 +0100
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Cezary Jackiewicz <cezary.jackiewicz@...il.com>
Cc:	Darren Hart <dvhart@...radead.org>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	Guenter Roeck <linux@...ck-us.net>,
	Matthew Garrett <matthew.garrett@...ula.com>,
	stable@...r.kernel.org
Subject: Re: [RFT PATCH v2 2/2] compal-laptop: Check return value of
 power_supply_register

On pią, 2015-02-20 at 14:04 +0100, Krzysztof Kozlowski wrote:
> The return value of power_supply_register() call was not checked and
> even on error probe() function returned 0. If registering failed then
> during unbind the driver tried to unregister power supply which was not
> actually registered.
> 
> This could lead to memory corruption because power_supply_unregister()
> unconditionally cleans up given power supply.
> 
> Fix this by checking return status of power_supply_register() call. In
> case of failure, clean up sysfs entries and fail the probe.
> 

(...)

>  
> @@ -1072,6 +1074,7 @@ static int compal_remove(struct platform_device *pdev)
>  
>  	data = platform_get_drvdata(pdev);
>  	power_supply_unregister(&data->psy);
> +	/* FIXME: missing hwmon_device_unregister() */
>  
>  	sysfs_remove_group(&pdev->dev.kobj, &compal_platform_attr_group);


Crap, I forgot to remove the FIXME note. It is no longer needed because
patch 1 fixes this.

I'll resend. Sorry for the noise.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/