linux-kernel - Re: [PATCH 1/2] x86: fix output of show_stack_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150220000620.GC31467@pd.tnic>
Date:	Fri, 20 Feb 2015 01:06:20 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Adrien Schildknecht <adrien+dev@...ischi.me>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, rostedt@...dmis.org, heukelum@...tmail.fm,
	luto@...capital.net, adech.fo@...il.com,
	masami.hiramatsu.pt@...achi.com, akpm@...ux-foundation.org,
	a.ryabinin@...sung.com, fruggeri@...sta.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] x86: fix output of show_stack_log_lvl()

On Thu, Feb 19, 2015 at 11:43:15PM +0100, Adrien Schildknecht wrote:
> Prepend the log level at the message following a newline.
> It is not possible to use pr_cont after a newline, the log level will be
> reseted.
> 
> Signed-off-by: Adrien Schildknecht <adrien+dev@...ischi.me>
> ---
>  arch/x86/kernel/dumpstack_32.c | 9 ++++++---
>  arch/x86/kernel/dumpstack_64.c | 9 ++++++---
>  2 files changed, 12 insertions(+), 6 deletions(-)

So those two patches belong into one as they logically are one fix.
Please merge them.

Then, please change your commit message to the format:

"Problem is A.

We need to do B.

This patch does it or this patch does C in order fix it."

Something like that in free form. Being verbose is a good thing when
explaning why this fix is needed and for people looking at those commit
messages months and years from now.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/