linux-kernel - Re: [PATCH] ARM: dts: OMAP3-N900: Fix offset for smc91x ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150220152856.GH32521@atomide.com>
Date:	Fri, 20 Feb 2015 07:28:56 -0800
From:	Tony Lindgren <tony@...mide.com>
To:	Pali Rohár <pali.rohar@...il.com>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Benoît Cousson <bcousson@...libre.com>,
	Rob Herring <robh+dt@...nel.org>, linux-omap@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: OMAP3-N900: Fix offset for smc91x ethernet

* Pali Rohár <pali.rohar@...il.com> [150220 01:56]:
> On Friday 20 February 2015 10:24:35 Arnd Bergmann wrote:
> > On Thursday 19 February 2015 17:49:50 Pali Rohár wrote:
> > > Offset for smc91x must be zero otherwise smc91x linux kernel
> > > driver does not detect smc91x ethernet hardware in qemu
> > > N900 machine.
> > > 
> > > Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> > 
> > Is that the same offset on real hardware, or could this be a
> > mistake in the qemu model?
> > 
> > 	Arnd
> 
> In original Nokia 2.6.28 kernel is offset also set to 0, see:
> 
> https://gitorious.org/linux-n900/linux-n900/source/629fc5ab00cafb31272c478efa2c2b35fabd4c70:arch/arm/mach-omap2/board-rx51-peripherals.c#L42
> 
> https://gitorious.org/linux-n900/linux-n900/source/629fc5ab00cafb31272c478efa2c2b35fabd4c70:arch/arm/mach-omap2/board-rx51-peripherals.c#L274
> 
> Tony already tested offset 0 on real HW and wrote that it is
> working too, just show some warning. But qemu with offset 0x300
> does not work.

Yes it works with offset 0, except the smc91x warns about not
using the default offset 0x300 based on the EEPROM. As only
three address lines seem to be connected, we can use offset
0 just fine, and update the EEPROM configuration as needed.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/