linux-kernel - Re: [PATCH v2] x86: fix output of show_stack_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Feb 2015 10:03:24 -0800
From:	Joe Perches <joe@...ches.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Thomas Gleixner <tglx@...utronix.de>, luto@...capital.net,
	fruggeri@...sta.com, Steven Rostedt <rostedt@...dmis.org>,
	a.ryabinin@...sung.com, akpm@...ux-foundation.org, hpa@...or.com,
	Adrien Schildknecht <adrien+dev@...ischi.me>,
	linux-kernel@...r.kernel.org,
	Alexander van Heukelum <heukelum@...tmail.fm>, bp@...en8.de,
	adech.fo@...il.com, x86@...nel.org, mingo@...hat.com
Subject: Re: [PATCH v2] x86: fix output of show_stack_log_lvl()

On Fri, 2015-02-20 at 09:52 -0800, Linus Torvalds wrote:
> On Feb 20, 2015 9:40 AM, "Joe Perches" <joe@...ches.com> wrote:
> >
> > There are still a few dozen uses of this pattern:
> >
> >         pr_info("Some message line 1\nNext line: ");
> >         for (...)
> >                 pr_cont(" part %d", i);
> >         pr_cont('\n");
> 
> That, btw, is a buglet anyway.
> 
> We don't really support newlines in the middle of printouts any more. We
> used to, but it for deprecated. It doesn't really work with the "printk is
> a message packet" model.
> 
> Admittedly neither does the "pr_cont()" model, but pr_cont() is
> fundamentally useful, in a way that newlines in the middle are not (they
> can always just be split up, while the pr_cont() cannot generally be
> combined).
> 
> So we should generally try to get rid of the newline in the middle cases.

True. Also fix the pr_debug/dev_dbg cases
like drivers/dma/ppc4xx/adma.c:

static void prep_dma_pq_dbg(int id, dma_addr_t *dst, dma_addr_t *src,
			    unsigned int src_cnt)
{
	int i;

	pr_debug("\n%s(%d):\nsrc: ", __func__, id);
	for (i = 0; i < src_cnt; i++)
		pr_debug("\t0x%016llx ", src[i]);
	pr_debug("dst: ");
	for (i = 0; i < 2; i++)
		pr_debug("\t0x%016llx ", dst[i]);
}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/