linux-kernel - Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1424459434.5308.52.camel@x220>
Date:	Fri, 20 Feb 2015 20:10:34 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	David Cohen <david.a.cohen@...ux.intel.com>
Cc:	myungjoo.ham@...sung.com, cw00.choi@...sung.com,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	baolu.lu@...ux.intel.com
Subject: Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port
 controlled by GPIO(s)

On Fri, 2015-02-20 at 11:02 -0800, David Cohen wrote:
> On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote:
> > On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote:
> > > As always, comments are welcome.
> > 
> > Are nits welcome too?
> > 
> > > +MODULE_LICENSE("GPLv2");
> > 
> > You probably meant
> >     MODULE_LICENSE("GPL v2")
> > 
> > Didn't that trigger a warning or error?
> 
> checkpatch showed no warning about that, not even with --strict option.
> I believe both ways are fine. But I can add the space.

"GPLv2" is not mentioned in include/linux/license.h so, as I remember,
it would taint the kernel, and a warning will be printed when you load
that module.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/